【NPU】Added patch update verification for NPU CI#316
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a pre-commit lint step and a new script, update-npu-environment.sh, to manage and apply NPU environment patches dynamically within the Buildkite pipeline. While these additions improve the CI workflow, several critical issues were identified in the review. Specifically, the patch application check logic needs to be reversed to work correctly, a typo in the NPU device environment variable name must be fixed, and the script should be sourced rather than executed to persist environment variables. Additionally, leftover sleep 3600 debugging statements should be removed to prevent pipeline hangs, the new vllm_ascend_test.patch needs to be registered in the configuration, and the unused verify_all_patches function should be addressed.
Documentation build overview
42 files changed ·
|
yzeyu71
force-pushed
the
feat/ci-npu-patch
branch
7 times, most recently
from
1607c9e to
fbf7230
Compare
1. The NPU environment update and modification are extracted into the script for execution 2. CI adds judgment, and applies to the corresponding component when there is a patch update Signed-off-by: yangzeyu <532183776@qq.com>
yzeyu71
force-pushed
the
feat/ci-npu-patch
branch
12 times, most recently
from
f78e666 to
167ec9c
Compare
Signed-off-by: yangzeyu <532183776@qq.com>
yzeyu71
force-pushed
the
feat/ci-npu-patch
branch
7 times, most recently
from
d7f97ed to
1e6eab0
Compare
yzeyu71
force-pushed
the
feat/ci-npu-patch
branch
12 times, most recently
from
64d7f64 to
b83efa0
Compare
yzeyu71
force-pushed
the
feat/ci-npu-patch
branch
6 times, most recently
from
dffd887 to
5f3a7b8
Compare
Signed-off-by: yangzeyu <532183776@qq.com>
yzeyu71
force-pushed
the
feat/ci-npu-patch
branch
from
5f3a7b8 to
57f210d
Compare
2 participants
Summary
The configuration and code updates of the NPU environment in CI will be extracted into the script for execution, which is convenient for subsequent updates.
CI adds judgment, and applies to the corresponding component when there is a patch update in docker/npu-patch/
pipeline-npu.yaml will execute in a separate buildkite pipeline vime NPU CI and is deleted from the VIME CI.
update the image to the latest version quay.io/ascend/vime:0.3.0-a3-vllm0.22.1rc1
Test result
1、update patch apply in the docker success
2、Vime NPU CI